[phpMyAdmin Developers] Pull request issues

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[phpMyAdmin Developers] Pull request issues

Manish Bisht
Hi,

I have submitted following PR. 

But now there is some issue with testing. Can someone guide me to what was the error and how can I remove it. Any public link that explains this thing will also be helpful.

Thanks,
 
Manish Bisht


_______________________________________________
Developers mailing list
[hidden email]
https://lists.phpmyadmin.net/mailman/listinfo/developers
Reply | Threaded
Open this post in threaded view
|

Re: [phpMyAdmin Developers] Pull request issues

Isaac Bennetch
Hi Manish,

If you follow the Travis link, then click on any of the failing builds (such as the job #20260.1 which is the PHP 7.1 build), 



You can then look through the build log, which is a massive amount of text output that, after much scrolling, shows this error:

$ ./scripts/generate-mo --quiet

po/pa.po:41: 'msgstr' is not a valid PHP format string, unlike 'msgid'. Reason: The character that terminates the directive number 1 is not a valid conversion specifier.

msgfmt: found 1 fatal error

Error when compiling po/pa.po



The command "./scripts/generate-mo --quiet" exited with 1.


Which is not a file you modified and is an ongoing problem. Even the regular builds (that are testing the main branch) are having this error, so it's not something you've done. The problem is in the main repository, so anything including that file is currently failing.

It's safe to ignore it as part of your pull requests. 

_______________________________________________
Developers mailing list
[hidden email]
https://lists.phpmyadmin.net/mailman/listinfo/developers
Reply | Threaded
Open this post in threaded view
|

Re: [phpMyAdmin Developers] Pull request issues

Manish Bisht
Hi,

Also is there any php file/function present in code base that can fetch the results from database from the JavaScript function ?
In more detail I am in the JavaScript function and now I want the results from the database. It can be possible by sending the ajax request to the php file and get the data in response. So I want to know if there is similar kind of thing present in code base.

Thanks, 

Manish Bisht


On Mon, May 29, 2017 at 2:42 PM, Isaac Bennetch <[hidden email]> wrote:
Hi Manish,

If you follow the Travis link, then click on any of the failing builds (such as the job #20260.1 which is the PHP 7.1 build), 

image1.JPG

You can then look through the build log, which is a massive amount of text output that, after much scrolling, shows this error:

$ ./scripts/generate-mo --quiet

po/pa.po:41: 'msgstr' is not a valid PHP format string, unlike 'msgid'. Reason: The character that terminates the directive number 1 is not a valid conversion specifier.

msgfmt: found 1 fatal error

Error when compiling po/pa.po



The command "./scripts/generate-mo --quiet" exited with 1.


Which is not a file you modified and is an ongoing problem. Even the regular builds (that are testing the main branch) are having this error, so it's not something you've done. The problem is in the main repository, so anything including that file is currently failing.

It's safe to ignore it as part of your pull requests. 


_______________________________________________
Developers mailing list
[hidden email]
https://lists.phpmyadmin.net/mailman/listinfo/developers